voroskoi/pistike - Change WAJ2J7G4QZE4LLGGZNIQ3ZIBCR3CSFOH3V2NIK2JQPALFHARRNMAC

PriorityQueue was a bad idea

Created by voroskoi on January 22, 2023

WAJ2J7G4QZE4LLGGZNIQ3ZIBCR3CSFOH3V2NIK2JQPALFHARRNMAC

Dependencies

In channels

main

Change contents

Replacement in src/uci.zig at line 68 [3.32]

B:BD[3.2206] → [4.0:69]

    var ml = MoveList.init(gs.allocator, {});
    defer ml.deinit();

[3.2206]

[3.2241]

    var ml = try MoveList.init(0);

Replacement in src/uci.zig at line 71 [3.32]
B:BD[3.2273] → [4.70:107]
```
    while (ml.removeOrNull()) |mp| {
```
[3.2273]
[4.107]
```
    for (ml.slice()) |mp| {
```
Insertion in src/search.zig at line 8 [5.35]
[5.222]
[5.222]
```
const MovePrio = @import("Board.zig").MovePrio;
```

Replacement in src/search.zig at line 59 [5.35]

B:BD[5.1885] → [4.419:488]

    var ml = MoveList.init(gs.allocator, {});
    defer ml.deinit();

[5.1885]

[5.1920]

    var ml = try MoveList.init(0);

Insertion in src/search.zig at line 61 [5.35]

[5.1951]

    std.sort.sort(MovePrio, ml.slice(), {}, comptime MovePrio.moreThan);

Replacement in src/search.zig at line 63 [5.35]
B:BD[5.1952] → [4.489:526]
```
    while (ml.removeOrNull()) |mp| {
```
[5.1952]
[5.1987]
```
    for (ml.slice()) |mp| {
```

Replacement in src/search.zig at line 139 [5.35]

B:BD[5.3720] → [4.653:722]

    var ml = MoveList.init(gs.allocator, {});
    defer ml.deinit();

[5.3720]

[5.3755]

    var ml = try MoveList.init(0);

Insertion in src/search.zig at line 141 [5.35]

[5.3786]

    std.sort.sort(MovePrio, ml.slice(), {}, comptime MovePrio.moreThan);

Replacement in src/search.zig at line 143 [5.35]
B:BD[5.3787] → [4.723:760]
```
    while (ml.removeOrNull()) |mp| {
```
[5.3787]
[5.3817]
```
    for (ml.slice()) |mp| {
```
Replacement in src/perft.zig at line 19 [6.34]
B:BD[6.464] → [6.464:498]
```
        for (ml.slice()) |move| {
```
[6.409]
[7.0]
```
        for (ml.slice()) |mp| {
```

Replacement in src/perft.zig at line 23 [6.34]

B:BD[6.540] → [6.540:589]

            if (!self.gs.makeMove(move, .all)) {

[6.540]

[7.83]

            if (!self.gs.makeMove(mp.move, .all)) {

Replacement in src/perft.zig at line 38 [6.34]
B:BD[6.890] → [6.890:924]
```
        for (ml.slice()) |move| {
```
[6.890]
[7.157]
```
        for (ml.slice()) |mp| {
```

Replacement in src/perft.zig at line 42 [6.34]

B:BD[6.966] → [6.966:1015]

            if (!self.gs.makeMove(move, .all)) {

[6.966]

[7.240]

            if (!self.gs.makeMove(mp.move, .all)) {

Replacement in src/perft.zig at line 55 [6.34]
B:BD[6.1302] → [6.1302:1327]
```
            move.show();
```
[6.1302]
[6.1327]
```
            mp.move.show();
```

Replacement in src/perft.zig at line 62 [6.34]

B:BD[6.1421] → [8.381:461]

    var gs = try Board.GameState.init("8/2p5/3p4/KP5r/1R3p1k/8/4P1P1/8 w - -");

[6.1421]

[7.314]

    var gs = try Board.GameState.init(
        std.testing.allocator,
        "8/2p5/3p4/KP5r/1R3p1k/8/4P1P1/8 w - -",
    );

Replacement in src/perft.zig at line 80 [6.34]

B:BD[8.508] → [7.599:707]

    var gs = try Board.GameState.init("r3k2r/p1ppqpb1/bn2pnp1/3PN3/1p2P3/2N2Q1p/PPPBBPPP/R3K2R w KQkq - ");

[8.508]

[8.588]

    var gs = try Board.GameState.init(
        std.testing.allocator,
        "r3k2r/p1ppqpb1/bn2pnp1/3PN3/1p2P3/2N2Q1p/PPPBBPPP/R3K2R w KQkq - ",
    );

Replacement in src/main.zig at line 16 [9.50]

B:BD[4.1438] → [2.279:471]

            // "r3k2r/p1ppqpb1/bn2pnp1/3PN3/1p2P3/2N2Q1p/PPPBBPPP/R3K2R w KQkq - 0 1", // tricky
            "r2q1rk1/ppp2ppp/2n1bn2/2b1p3/3pP3/3P1NPP/PPP1NPB1/R1BQ1RK1 b - - 0 9", // cmk_pos

[4.1438]

[4.1518]

            "r3k2r/p1ppqpb1/bn2pnp1/3PN3/1p2P3/2N2Q1p/PPPBBPPP/R3K2R w KQkq - 0 1", // tricky
            // "r2q1rk1/ppp2ppp/2n1bn2/2b1p3/3pP3/3P1NPP/PPP1NPB1/R1BQ1RK1 b - - 0 9", // cmk_pos

Replacement in src/main.zig at line 21 [9.50]

B:BD[4.1531] → [4.1531:1797]

B:BD[4.1797] → [2.472:533]

        var moves = Board.MoveList.init(arena.allocator(), {});
        defer moves.deinit();
        try gs.generateMoves(&moves);
        while (moves.removeOrNull()) |mp| {
            mp.move.show();
            std.debug.print("{d}\n", .{mp.score});
        }
        std.debug.print("{s}", .{search.bestMove(&gs, 5)});

[4.1531]

[4.1797]

        std.debug.print("{s}", .{search.bestMove(&gs, 3)});

Insertion in src/main.zig at line 72 [9.50]
[3.4809]
[9.3467]
```
    // _ = @import("perft.zig");
```
Replacement in src/Board.zig at line 105 [10.16071]
B:BD[4.2662] → [4.2662:2688]
```
const MovePrio = struct {
```
[4.2662]
[4.2688]
```
pub const MovePrio = struct {
```

Replacement in src/Board.zig at line 109 [10.16071]

B:BD[4.2726] → [4.2726:2798]

    fn moreThan(context: void, a: @This(), b: @This()) std.math.Order {

[4.2726]

[4.2798]

    pub fn moreThan(context: void, a: @This(), b: @This()) bool {

Replacement in src/Board.zig at line 111 [10.16071]

B:BD[4.2819] → [2.534:565]

∅:D[2.565] → [4.2910:2970]

B:BD[4.2910] → [4.2910:2970]

        if (a.score > b.score)
            return .lt
        else
            return .gt;

[4.2819]

[4.2970]

        if (a.score > b.score) return true;
        return false;

Replacement in src/Board.zig at line 116 [10.16071]

B:BD[4.2978] → [4.2978:3053]

pub const MoveList = std.PriorityQueue(MovePrio, void, MovePrio.moreThan);

[4.2978]

[11.538]

pub const MoveList = std.BoundedArray(MovePrio, 128);

Replacement in src/Board.zig at line 519 [10.16071]

B:BD[4.3313] → [4.3313:3406]

                        try ml.add(MovePrio{ .move = move, .score = self.scoreMove(move) });

[4.3313]

[10.32838]

                        try ml.append(MovePrio{ .move = move, .score = self.scoreMove(move) });

Replacement in src/Board.zig at line 528 [10.16071]

B:BD[4.3692] → [4.3692:3778]

                        try ml.add(.{ .move = move, .score = self.scoreMove(move) });

[4.3692]

[4.3778]

                        try ml.append(.{ .move = move, .score = self.scoreMove(move) });

Replacement in src/Board.zig at line 542 [10.16071]

B:BD[4.3875] → [4.3875:3961]

                        try ml.add(.{ .move = move, .score = self.scoreMove(move) });

[4.3875]

[10.33794]

                        try ml.append(.{ .move = move, .score = self.scoreMove(move) });

Replacement in src/Board.zig at line 563 [10.16071]

B:BD[4.4036] → [4.4036:4122]

                        try ml.add(.{ .move = move, .score = self.scoreMove(move) });

[4.4036]

[10.34600]

                        try ml.append(.{ .move = move, .score = self.scoreMove(move) });

Replacement in src/Board.zig at line 572 [10.16071]

B:BD[4.4189] → [4.4189:4271]

                    try ml.add(.{ .move = move, .score = self.scoreMove(move) });

[4.4189]

[10.34941]

                    try ml.append(.{ .move = move, .score = self.scoreMove(move) });

Replacement in src/Board.zig at line 593 [10.16071]

B:BD[4.4338] → [4.4338:4420]

                    try ml.add(.{ .move = move, .score = self.scoreMove(move) });

[4.4338]

[10.35780]

                    try ml.append(.{ .move = move, .score = self.scoreMove(move) });

Replacement in src/Board.zig at line 637 [10.16071]

B:BD[4.4487] → [4.4487:4569]

                    try ml.add(.{ .move = move, .score = self.scoreMove(move) });

[4.4487]

[10.37280]

                    try ml.append(.{ .move = move, .score = self.scoreMove(move) });

Replacement in src/Board.zig at line 676 [10.16071]

B:BD[4.4636] → [4.4636:4718]

                    try ml.add(.{ .move = move, .score = self.scoreMove(move) });

[4.4636]

[10.38633]

                    try ml.append(.{ .move = move, .score = self.scoreMove(move) });

Replacement in src/Board.zig at line 713 [10.16071]

B:BD[4.4785] → [4.4785:4867]

                    try ml.add(.{ .move = move, .score = self.scoreMove(move) });

[4.4785]

[10.40419]

                    try ml.append(.{ .move = move, .score = self.scoreMove(move) });

Replacement in src/Board.zig at line 720 [10.16071]

B:BD[4.4934] → [4.4934:5016]

                    try ml.add(.{ .move = move, .score = self.scoreMove(move) });

[4.4934]

[10.40697]

                    try ml.append(.{ .move = move, .score = self.scoreMove(move) });

Replacement in src/Board.zig at line 959 [10.16071]

B:BD[10.41360] → [4.7370:7439]

    var ml = MoveList.init(gs.allocator, {});
    defer ml.deinit();

[10.41360]

[6.8047]

    var ml = try MoveList.init(0);