akkartik/pensieve.love - Change BE7D2TCTDPXQ6SLON3OL6G7PLZZMDRFHTJ4EL6MMI6R4RF53F2AAC

oh, edit.draw ensures cursor_y falls back to screen height

So keychord_pressed_on_editable_pane can currently never early exit because cursor_y is too high. So we can toss out some stuff that can't ever possibly trigger (and would help us here if it did)

Too many special cases, too much clamping of variables.

Created by Kartik K. Agaram on August 16, 2022

BE7D2TCTDPXQ6SLON3OL6G7PLZZMDRFHTJ4EL6MMI6R4RF53F2AAC

Dependencies

In channels

main

Change contents

Deletion in main.lua at line 406 [5.2]
B:BD[4.1203] → [4.1203:1227]
```
    pane.cursor_y = nil
```
Deletion in main.lua at line 412 [5.2]
B:BD[4.1440] → [4.1440:1580]
∅:D[6.99] → [7.5952:5962]
∅:D[8.424] → [7.5952:5962]
∅:D[9.477] → [7.5952:5962]
∅:D[10.546] → [7.5952:5962]
∅:D[11.550] → [7.5952:5962]
∅:D[4.1580] → [7.5952:5962]
B:BD[7.5952] → [7.5952:5962]
```
      if pane.editable and Surface.cursor_on_screen_check then
        assert(pane.cursor_y)
        Surface.cursor_on_screen_check = false
      end
```
Deletion in main.lua at line 728 [5.2]
B:BD[2.56] → [2.56:98]
```
    Surface.cursor_on_screen_check = true
```

Insertion in main.lua at line 1101 [5.2]

[3.1647]

  print('keychord_pressed_on_editable_pane: cursor_y is', pane.cursor_y)

Deletion in main.lua at line 1125 [5.2]
∅:D[12.422] → [13.508:629]
∅:D[3.2082] → [13.508:629]
B:BD[13.508] → [13.508:629]
```
    Surface.cursor_on_screen_check = true  -- cursor was on screen before keystroke, so it should remain on screen after
```
Deletion in main.lua at line 1212 [5.2]
B:BD[14.10278] → [14.10278:10324]
```
        Surface.cursor_on_screen_check = true
```
Deletion in main.lua at line 1222 [5.2]
B:BD[14.10625] → [14.10625:10671]
```
        Surface.cursor_on_screen_check = true
```

oh, edit.draw ensures cursor_y falls back to screen height

Dependencies

In channels

Change contents

Deletion in main.lua at line 406 [5.2]

Deletion in main.lua at line 412 [5.2]

Deletion in main.lua at line 728 [5.2]

Insertion in main.lua at line 1101 [5.2]

Deletion in main.lua at line 1125 [5.2]

Deletion in main.lua at line 1212 [5.2]

Deletion in main.lua at line 1222 [5.2]