grahamc/hydra2 - Change 6IQ5AEQNRPMVB2FRDLDCSN6JU3HUPLV4MBTDIR5MJT7TWHKWG6JQC

HIpChatNotification: $build -> $topbuild, $b -> $build (perlcritic)

Created by Graham Christensen on August 20, 2021

6IQ5AEQNRPMVB2FRDLDCSN6JU3HUPLV4MBTDIR5MJT7TWHKWG6JQC

Dependencies

In channels

main

Change contents

Replacement in src/lib/Hydra/Plugin/HipChatNotification.pm at line 14 [6.47]
B:BD[6.208] → [6.208:250]
```
    my ($self, $build, $dependents) = @_;
```
[6.208]
[6.250]
```
    my ($self, $topbuild, $dependents) = @_;
```

Replacement in src/lib/Hydra/Plugin/HipChatNotification.pm at line 24 [6.47]

B:BD[6.554] → [6.554:683]

    foreach my $b ($build, @{$dependents}) {
        my $prevBuild = getPreviousBuild($b);
        my $jobName = showJobName $b;

[6.554]

[6.683]

    foreach my $build ($topbuild, @{$dependents}) {
        my $prevBuild = getPreviousBuild($build);
        my $jobName = showJobName $build;

Replacement in src/lib/Hydra/Plugin/HipChatNotification.pm at line 33 [6.47]

B:BD[6.844] → [3.41:121]

            next if ! $force && ($b->buildstatus == 4 || $b->buildstatus == 3);

[6.844]

[6.910]

            next if ! $force && ($build->buildstatus == 4 || $build->buildstatus == 3);

Replacement in src/lib/Hydra/Plugin/HipChatNotification.pm at line 37 [6.47]

B:BD[6.1045] → [3.122:222]

            next if ! $force && defined $prevBuild && ($b->buildstatus == $prevBuild->buildstatus);

[6.1045]

[6.1133]

            next if ! $force && defined $prevBuild && ($build->buildstatus == $prevBuild->buildstatus);

Replacement in src/lib/Hydra/Plugin/HipChatNotification.pm at line 40 [6.47]

B:BD[6.1205] → [6.1205:1262]

            push @{$rooms{$room->{room}}->{builds}}, $b;

[6.1205]

[6.1262]

            push @{$rooms{$room->{room}}->{builds}}, $build;

Replacement in src/lib/Hydra/Plugin/HipChatNotification.pm at line 46 [6.47]

B:BD[7.2729] → [8.1200:1281]

    my ($authors, $nrCommits) = getResponsibleAuthors($build, $self->{plugins});

[7.1987]

[7.2972]

    my ($authors, $nrCommits) = getResponsibleAuthors($topbuild, $self->{plugins});

Replacement in src/lib/Hydra/Plugin/HipChatNotification.pm at line 51 [6.47]

B:BD[6.1389] → [6.1389:1458]

        my @deps = grep { $_->id != $build->id } @{$room->{builds}};

[6.1389]

[6.1458]

        my @deps = grep { $_->id != $topbuild->id } @{$room->{builds}};

Replacement in src/lib/Hydra/Plugin/HipChatNotification.pm at line 54 [6.47]

B:BD[6.1525] → [5.0:250]

            $build->buildstatus == 0 ? "$baseurl/static/images/checkmark_16.png" :
            $build->buildstatus == 2 ? "$baseurl/static/images/dependency_16.png" :
            $build->buildstatus == 4 ? "$baseurl/static/images/cancelled_16.png" :

[6.1525]

[5.250]

            $topbuild->buildstatus == 0 ? "$baseurl/static/images/checkmark_16.png" :
            $topbuild->buildstatus == 2 ? "$baseurl/static/images/dependency_16.png" :
            $topbuild->buildstatus == 4 ? "$baseurl/static/images/cancelled_16.png" :

Replacement in src/lib/Hydra/Plugin/HipChatNotification.pm at line 61 [6.47]

B:BD[6.1887] → [4.1086:1257]

        $msg .= "Job <a href='$baseurl/job/${\$build->get_column('project')}/${\$build->get_column('jobset')}/${\$build->get_column('job')}'>${\showJobName($build)}</a>";

[6.1887]

[6.2034]

        $msg .= "Job <a href='$baseurl/job/${\$topbuild->get_column('project')}/${\$topbuild->get_column('jobset')}/${\$topbuild->get_column('job')}'>${\showJobName($topbuild)}</a>";

Replacement in src/lib/Hydra/Plugin/HipChatNotification.pm at line 63 [6.47]

B:BD[6.2104] → [6.2104:2196]

        $msg .= ": <a href='$baseurl/build/${\$build->id}'>" . showStatus($build) . "</a>";

[6.2104]

[6.2196]

        $msg .= ": <a href='$baseurl/build/${\$topbuild->id}'>" . showStatus($topbuild) . "</a>";

Replacement in src/lib/Hydra/Plugin/HipChatNotification.pm at line 82 [6.47]

∅:D[2.52] → [6.2592:2660]

B:BD[6.2592] → [6.2592:2660]

            color => $build->buildstatus == 0 ? 'green' : 'red' });

[2.52]

[6.2660]

            color => $topbuild->buildstatus == 0 ? 'green' : 'red' });