grahamc/hydra2 - Change QTC3SYBMNNTPZHQGXRMV5GU5KDODGXPIM3TIGWBAF7HDKNDKTCXQC

Jobset page: Load the jobs and status tabs on demand

This makes the jobset page much smaller and faster. (E.g. for nixpkgs:trunk, this page was ~2.5 MB.)

Created by Eelco Dolstra on February 22, 2013

QTC3SYBMNNTPZHQGXRMV5GU5KDODGXPIM3TIGWBAF7HDKNDKTCXQC

Dependencies

In channels

main

Change contents

Replacement in src/lib/Hydra/Controller/Jobset.pm at line 24 [5.104]

B:BD[5.702] → [6.0:57]

sub jobsetIndex {
    my ($self, $c, $forceStatus) = @_;

[5.702]

sub index : Chained('jobset') PathPart('') Args(0) {
    my ($self, $c) = @_;

Replacement in src/lib/Hydra/Controller/Jobset.pm at line 32 [5.104]

B:BD[7.100] → [7.100:258]

B:BD[7.258] → [8.0:152]

∅:D[8.152] → [7.409:491]

B:BD[7.409] → [7.409:491]

    # Get the active / inactive jobs in this jobset.
    my @jobs = $c->stash->{jobset}->jobs->search(
        { },
        { select => [
            "name",
            \ ("exists (select 1 from builds where project = '$projectName' and jobset = '$jobsetName' and job = me.name and isCurrent = 1) as active")
          ]
        , as => ["name", "active"]
        , order_by => ["name"] });

[7.100]

[9.335]

    $c->stash->{evals} = getEvals($self, $c, scalar $c->stash->{jobset}->jobsetevals, 0, 10);
    ($c->stash->{latestEval}) = $c->stash->{jobset}->jobsetevals->search({}, { limit => 1, order_by => ["id desc"] });
}
sub jobs_tab : Chained('jobset') PathPart('jobs-tab') Args(0) {
    my ($self, $c) = @_;
    $c->stash->{template} = 'jobset-jobs-tab.tt';

Replacement in src/lib/Hydra/Controller/Jobset.pm at line 44 [5.104]

B:BD[7.562] → [7.562:592]

B:BD[7.647] → [7.647:763]

    foreach my $job (@jobs) {
        if ($job->get_column('active')) {
            push @{$c->stash->{activeJobs}}, $job->name;
        } else {

[7.562]

[7.763]


    (my $latestEval) = $c->stash->{jobset}->jobsetevals->search(
        { hasnewbuilds => 1}, { limit => 1, order_by => ["id desc"] });
    my %activeJobs;
    if (defined $latestEval) {
        foreach my $build ($latestEval->builds->search({}, { order_by => ["job"], select => ["job"] })) {
            my $job = $build->get_column("job");
            if (!defined $activeJobs{$job}) {
                $activeJobs{$job} = 1;
                push @{$c->stash->{activeJobs}}, $job;
            }
        }
    }
    foreach my $job ($c->stash->{jobset}->jobs->search({}, { order_by => ["name"] })) {
        if (!defined $activeJobs{$job->name}) {

Insertion in src/lib/Hydra/Controller/Jobset.pm at line 64 [5.104]
[7.838]
[10.0]
```
}
```

Replacement in src/lib/Hydra/Controller/Jobset.pm at line 66 [5.104]

B:BD[10.1] → [11.0:94]

    $c->stash->{evals} = getEvals($self, $c, scalar $c->stash->{jobset}->jobsetevals, 0, 10);

[10.1]

[4.0]


sub status_tab : Chained('jobset') PathPart('status-tab') Args(0) {
    my ($self, $c) = @_;
    $c->stash->{template} = 'jobset-status-tab.tt';

Replacement in src/lib/Hydra/Controller/Jobset.pm at line 71 [5.104]

B:BD[4.1] → [4.1:120]

    ($c->stash->{latestEval}) = $c->stash->{jobset}->jobsetevals->search({}, { limit => 1, order_by => ["id desc"] });

[4.1]

[12.4]

    # FIXME: use latest eval instead of iscurrent.

Replacement in src/lib/Hydra/Controller/Jobset.pm at line 82 [5.104]

B:BD[12.9] → [3.0:68]

∅:D[13.67] → [7.844:978]

∅:D[3.68] → [7.844:978]

B:BD[6.158] → [7.844:978]

B:BD[7.978] → [14.3623:3851]

∅:D[15.261] → [7.1218:1250]

∅:D[16.2169] → [7.1218:1250]

∅:D[14.3851] → [7.1218:1250]

B:BD[7.1218] → [7.1218:1250]

B:BD[7.1250] → [14.3852:4073]

∅:D[14.4073] → [16.2427:2467]

B:BD[16.2427] → [16.2427:2467]

∅:D[16.2467] → [7.1524:1753]

B:BD[7.1524] → [7.1524:1753]

B:BD[7.1753] → [17.2158:2291]

    if($forceStatus || scalar(@{$c->stash->{activeJobs}}) <= 100) {
        my @select = ();
        my @as = ();
        push(@select, "job"); push(@as, "job");
        foreach my $system (@systems) {
            push(@select, "(select buildstatus from Builds b where b.id = (select max(id) from Builds t where t.project = me.project and t.jobset = me.jobset and t.job = me.job and t.system = '$system' and t.iscurrent = 1 ))");
            push(@as, $system);
            push(@select, "(select b.id from Builds b where b.id = (select max(id) from Builds t where t.project = me.project and t.jobset = me.jobset and t.job = me.job and t.system = '$system' and t.iscurrent = 1 ))");
            push(@as, "$system-build");
        }
        $c->stash->{activeJobsStatus} =
            [ $c->model('DB')->resultset('ActiveJobsForJobset')->search(
                  {},
                  { bind => [$c->stash->{project}->name, $c->stash->{jobset}->name]
                  , select => \@select
                  , as => \@as
                  , order_by => ["job"]
                  })];

[12.9]

[7.1858]

    my @select = ();
    my @as = ();
    push(@select, "job"); push(@as, "job");
    foreach my $system (@systems) {
        push(@select, "(select buildstatus from Builds b where b.id = (select max(id) from Builds t where t.project = me.project and t.jobset = me.jobset and t.job = me.job and t.system = '$system' and t.iscurrent = 1 ))");
        push(@as, $system);
        push(@select, "(select b.id from Builds b where b.id = (select max(id) from Builds t where t.project = me.project and t.jobset = me.jobset and t.job = me.job and t.system = '$system' and t.iscurrent = 1 ))");
        push(@as, "$system-build");

Deletion in src/lib/Hydra/Controller/Jobset.pm at line 91 [5.104]
B:BD[7.1864] → [12.10:11]
∅:D[18.361] → [5.819:821]
∅:D[19.405] → [5.819:821]
∅:D[8.483] → [5.819:821]
∅:D[9.502] → [5.819:821]
∅:D[20.1262] → [5.819:821]
∅:D[21.1528] → [5.819:821]
∅:D[14.4193] → [5.819:821]
B:BD[5.819] → [5.819:821]
B:BD[5.821] → [2.2:3]
∅:D[2.3] → [5.821:822]
B:BD[5.821] → [5.821:822]
B:BD[5.822] → [6.159:212]
B:BD[6.212] → [2.4:60]
∅:D[2.60] → [6.264:266]
B:BD[6.264] → [6.264:266]
B:BD[6.266] → [2.61:62]
```
}
sub index : Chained('jobset') PathPart('') Args(0) {
    my ($self, $c) = @_;
    jobsetIndex($self, $c, 0);
}
```

Replacement in src/lib/Hydra/Controller/Jobset.pm at line 92 [5.104]

B:BD[6.267] → [6.267:330]

B:BD[6.330] → [2.63:133]

sub indexWithStatus : Chained('jobset') PathPart('') Args(1) {
    my ($self, $c, $forceStatus) = @_;
    jobsetIndex($self, $c, 1);

[6.267]

[6.396]

    $c->stash->{activeJobsStatus} = [
        $c->model('DB')->resultset('ActiveJobsForJobset')->search(
            {},
            { bind => [$c->stash->{project}->name, $c->stash->{jobset}->name]
            , select => \@select
            , as => \@as
            , order_by => ["job"]
            }) ];

File addition: jobset-jobs-tab.tt (----------)

[22.1486]

[% PROCESS common.tt %]
<p>This jobset currently contains the following [% activeJobs.size %] jobs:
  <blockquote>
    [% IF activeJobs.size == 0 %]<em>(none)</em>[% END %]
    [% FOREACH j IN activeJobs %][% INCLUDE renderJobName project=project.name jobset=jobset.name job=j %]<br/>[% END %]
  </blockquote>
</p>
<p>This jobset used to contain the following [% inactiveJobs.size %] jobs:
  <blockquote>
    [% IF inactiveJobs.size == 0 %]<em>(none)</em>[% END %]
    [% FOREACH j IN inactiveJobs %][% INCLUDE renderJobName project=project.name jobset=jobset.name job=j %]<br/>[% END %]
  </blockquote>
</p>

File addition: jobset-status-tab.tt (----------)

[22.1486]

[% PROCESS common.tt %]
<table class="table table-striped table-condensed">
  <thead><tr><th>Job</th>[% FOREACH s IN systems %]<th>[% s.system %]</th>[% END %]</tr></thead>
  <tbody>
    [% odd = 0 %]
    [% FOREACH j IN activeJobsStatus %]
      <tr class="[% IF odd %] odd [% END; odd = !odd %]">
        <td>[% INCLUDE renderJobName project=project.name jobset = jobset.name job = j.get_column('job') %]</td>
        [% FOREACH s IN systems %]
          [% system = s.system %]
          [% systemStatus = j.get_column(system) %]
          <td class="centered">
            [% IF systemStatus != undef %]
              <a href="[% c.uri_for('/build' j.get_column(system _ '-build') ) %]">
                [% INCLUDE renderBuildStatusIcon buildstatus=systemStatus size=16 %]
              </a>
            [% END %]
          </td>
        [% END %]
      </tr>
    [% END %]
  </tbody>
</table>

Replacement in src/root/jobset.tt at line 49 [9.8409]

∅:D[23.210] → [24.6829:6912]

B:BD[24.6829] → [24.6829:6912]

  <li><a href="#tabs-jobs" data-toggle="tab">Jobs ([% activeJobs.size %])</a></li>

[23.210]

[24.6912]

  <li><a href="#tabs-jobs" data-toggle="tab">Jobs</a></li>

Deletion in src/root/jobset.tt at line 88 [9.8409]

B:BD[23.707] → [23.707:751]

∅:D[23.751] → [24.7252:7282]

B:BD[25.27517] → [24.7252:7282]

B:BD[24.7304] → [24.7304:8194]

∅:D[24.8194] → [26.706:728]

B:BD[26.706] → [26.706:728]

B:BD[26.728] → [24.8195:8475]


  <div id="tabs-status" class="tab-pane">
    [% IF activeJobsStatus %]
      <table class="table table-striped table-condensed">
        <thead><tr><th>Job</th>[% FOREACH s IN systems %]<th>[% s.system %]</th>[% END %]</tr></thead>
        <tbody>
          [% odd = 0 %]
          [% FOREACH j IN activeJobsStatus %]
            <tr class="[% IF odd %] odd [% END; odd = !odd %]">
              <td>[% INCLUDE renderJobName project=project.name jobset = jobset.name job = j.get_column('job') %]</td>
              [% FOREACH s IN systems %]
                [% system = s.system %]
                [% systemStatus = j.get_column(system) %]
                <td class="centered">
                  [% IF systemStatus != undef %]
                    <a href="[% c.uri_for('/build' j.get_column(system _ '-build') ) %]">
                      [% INCLUDE renderBuildStatusIcon buildstatus=systemStatus size=16 %]
                    </a>
                  [% END %]
                </td>
              [% END %]
            </tr>
          [% END %]
        </tbody>
      </table>
    [% ELSE %]
      <h2>Status</h2>
      <p>
        [ <a href="[% c.uri_for('/jobset' project.name jobset.name 'with-status' ) %]">Show status overview</a> ]
      </p>
    [% END %]

Replacement in src/root/jobset.tt at line 89 [9.8409]

B:BD[9.13217] → [24.8476:8485]

  </div>

[9.13217]

[7.1987]

  [% INCLUDE makeLazyTab tabName="tabs-status" uri=c.uri_for('/jobset' project.name jobset.name "status-tab") %]

Replacement in src/root/jobset.tt at line 135 [9.8409]

B:BD[25.30587] → [24.10071:10111]

  <div id="tabs-jobs" class="tab-pane">

[25.30587]

[25.30686]

  [% INCLUDE makeLazyTab tabName="tabs-jobs" uri=c.uri_for('/jobset' project.name jobset.name "jobs-tab") %]

Deletion in src/root/jobset.tt at line 137 [9.8409]

B:BD[25.30687] → [24.10112:10192]

B:BD[25.30995] → [24.10193:10428]

∅:D[24.10428] → [9.13217:13218]

∅:D[21.25463] → [9.13217:13218]

∅:D[25.31024] → [9.13217:13218]

B:BD[9.13217] → [9.13217:13218]

B:BD[9.13218] → [24.10429:10508]

B:BD[25.31067] → [24.10509:10748]

∅:D[24.10748] → [9.13244:13245]

B:BD[9.13244] → [9.13244:13245]

B:BD[27.2589] → [27.2589:2598]

∅:D[27.2598] → [9.14462:14463]

∅:D[28.8789] → [9.14462:14463]

B:BD[9.14462] → [9.14462:14463]

    <p>This jobset currently contains the following [% activeJobs.size %] jobs:
      <blockquote>
        [% IF activeJobs.size == 0 %]<em>(none)</em>[% END %]
        [% FOREACH j IN activeJobs %][% INCLUDE renderJobName project=project.name jobset=jobset.name job=j %]<br/>[% END %]
      </blockquote>
    </p>
    <p>This jobset used to contain the following [% inactiveJobs.size %] jobs:
      <blockquote>
        [% IF inactiveJobs.size == 0 %]<em>(none)</em>[% END %]
        [% FOREACH j IN inactiveJobs %][% INCLUDE renderJobName project=project.name jobset=jobset.name job=j %]<br/>[% END %]
      </blockquote>
    </p>
  </div>