voroskoi/pistike - Change 3QZ5Y55BFUIRG5HZNURRD5Y5SY3VD5CYEZEXCZHBIDEME6MIQQBQC

Move history belongs to GameState

Created by voroskoi on February 1, 2023

3QZ5Y55BFUIRG5HZNURRD5Y5SY3VD5CYEZEXCZHBIDEME6MIQQBQC

Dependencies

In channels

main

Change contents

Replacement in src/zobrist.zig at line 37 [2.36]
B:BD[2.926] → [2.926:961]
```
    gs.hash = 0; // starting poing
```
[2.926]
[2.961]
```
    gs.hash = 0; // starting point
```
Insertion in src/zobrist.zig at line 67 [2.36]
[2.1778]
[2.1778]
```
    defer gs.deinit();
```
Insertion in src/uci.zig at line 16 [7.32]
[5.242]
[6.0]
```
    defer gs.deinit();
```

Replacement in src/uci.zig at line 65 [7.32]

B:BD[5.1407] → [3.0:139]

                std.log.debug("clearing transposition table", .{});
                search.?.tt.clear(); // XXX: is this really necessary?

[5.1407]

                // std.log.debug("clearing transposition table", .{});
                // search.?.tt.clear(); // XXX: is this really necessary?

Insertion in src/uci.zig at line 77 [7.32]

[8.272]

[5.1604]

                    std.log.debug("empty moves history", .{});
                    gs.history.clearRetainingCapacity();

Insertion in src/uci.zig at line 169 [7.32]

[7.1882]

            try gs.history.put(gs.hash, {});

Insertion in src/uci.zig at line 214 [7.32]
[9.355]
[7.3339]
```
    defer gs.deinit();
```
Insertion in src/uci.zig at line 241 [7.32]
[9.418]
[7.3992]
```
    defer gs.deinit();
```
Insertion in src/perft.zig at line 81 [12.34]
[10.719]
[11.314]
```
    defer gs.deinit();
```
Insertion in src/perft.zig at line 101 [12.34]
[10.874]
[13.588]
```
    defer gs.deinit();
```
Insertion in src/nnue.zig at line 124 [15.33]
[9.1029]
[14.166]
```
        defer gs.deinit();
```
Insertion in src/nnue.zig at line 130 [15.33]
[9.1101]
[14.407]
```
        defer gs.deinit();
```
Insertion in src/nnue.zig at line 136 [15.33]
[9.1173]
[14.621]
```
        defer gs.deinit();
```
Insertion in src/nnue.zig at line 142 [15.33]
[9.1245]
[14.862]
```
        defer gs.deinit();
```
Insertion in src/main.zig at line 23 [17.50]
[9.1529]
[16.525]
```
        defer gs.deinit();
```
Insertion in src/eval.zig at line 152 [18.33]
[9.2112]
[15.5063]
```
        defer gs.deinit();
```
Insertion in src/eval.zig at line 162 [18.33]
[9.2274]
[15.5297]
```
        defer gs.deinit();
```
Insertion in src/eval.zig at line 172 [18.33]
[9.2438]
[15.5502]
```
        defer gs.deinit();
```
Insertion in src/eval.zig at line 182 [18.33]
[9.2606]
[15.5721]
```
        defer gs.deinit();
```

Deletion in src/Search.zig at line 36 [19.35]

B:BD[4.76] → [4.76:408]

∅:D[20.112] → [21.1000:1003]

∅:D[22.373] → [21.1000:1003]

∅:D[4.408] → [21.1000:1003]

B:BD[21.1000] → [21.1000:1003]

B:BD[21.1003] → [4.409:485]

∅:D[4.485] → [21.1003:1004]

B:BD[21.1003] → [21.1003:1004]

const HashHistoryContext = struct {
    pub const hash = hashFn;
    pub const eql = eqlFn;
    fn hashFn(self: @This(), key: u64) u32 {
        _ = self;
        return @truncate(u32, key);
    }
    fn eqlFn(self: @This(), a: u64, b: u64, b_index: usize) bool {
        _ = self;
        _ = b_index;
        return a == b;
    }
};
const HashHistory = std.ArrayHashMap(u64, void, HashHistoryContext, false);

Deletion in src/Search.zig at line 48 [19.35]
∅:D[20.141] → [21.1069:1070]
∅:D[8.2414] → [21.1069:1070]
B:BD[21.1069] → [21.1069:1070]
B:BD[21.1070] → [4.486:549]
```
    // Move history
    hash_history: HashHistory = undefined,
```

Deletion in src/Search.zig at line 75 [19.35]

B:BD[8.2541] → [4.551:611]

            .hash_history = HashHistory.init(gs.allocator),

Replacement in src/Search.zig at line 78 [19.35]
B:BD[8.2559] → [4.612:653]
```
    pub fn deinit(self: *@This()) void {
```
[8.2559]
[8.2599]
```
    pub fn deinit(self: @This()) void {
```
Deletion in src/Search.zig at line 80 [19.35]
B:BD[8.2625] → [4.654:690]
```
        self.hash_history.deinit();
```

Replacement in src/Search.zig at line 185 [19.35]

B:BD[4.727] → [4.727:786]

        if (self.hash_history.contains(self.state.hash)) {

[4.727]

[4.786]

        if (self.state.history.contains(self.state.hash)) {

Replacement in src/Search.zig at line 245 [19.35]

B:BD[23.1772] → [4.952:1016]

                try self.hash_history.put(self.state.hash, {});

[23.1772]

[24.41]

                try self.state.history.put(self.state.hash, {});

Replacement in src/Search.zig at line 260 [19.35]

B:BD[23.1805] → [4.1017:1062]

                _ = self.hash_history.pop();

[23.1805]

[25.451]

                _ = self.state.history.pop();

Replacement in src/Search.zig at line 297 [19.35]

B:BD[5.7933] → [4.1063:1123]

            try self.hash_history.put(self.state.hash, {});

[5.7933]

[4.1123]

            try self.state.history.put(self.state.hash, {});

Replacement in src/Search.zig at line 301 [19.35]

B:BD[5.8019] → [4.1125:1170]

                _ = self.hash_history.pop();

[5.8019]

                _ = self.state.history.pop();

Replacement in src/Search.zig at line 347 [19.35]

B:BD[5.10142] → [4.1171:1212]

            _ = self.hash_history.pop();

[5.10142]

[19.2295]

            _ = self.state.history.pop();

Insertion in src/Board.zig at line 207 [26.16071]
[2.3004]
[9.3054]
```
    history: HashHistory = undefined,
```

Insertion in src/Board.zig at line 209 [26.16071]

[9.3088]

[27.56]


    const HashHistoryContext = struct {
        pub const hash = hashFn;
        pub const eql = eqlFn;
        fn hashFn(self: @This(), key: u64) u32 {
            _ = self;
            return @truncate(u32, key);
        }
        fn eqlFn(self: @This(), a: u64, b: u64, b_index: usize) bool {
            _ = self;
            _ = b_index;
            return a == b;
        }
    };
    const HashHistory = std.ArrayHashMap(u64, void, HashHistoryContext, false);

Insertion in src/Board.zig at line 237 [26.16071]
[9.3238]
[2.3005]
```
        gs.history = HashHistory.init(allocator);
```

Insertion in src/Board.zig at line 244 [26.16071]

[26.20987]

    }
    pub fn deinit(self: *@This()) void {
        self.history.deinit();

Insertion in src/Board.zig at line 976 [26.16071]
[9.7295]
[26.41004]
```
    defer game.deinit();
```
Insertion in src/Board.zig at line 991 [26.16071]
[9.7369]
[26.41359]
```
    defer gs.deinit();
```
Insertion in src/Board.zig at line 1002 [26.16071]
[9.7513]
[26.41634]
```
    defer gs.deinit();
```

Move history belongs to GameState

Dependencies

In channels

Change contents

Replacement in src/zobrist.zig at line 37 [2.36]

Insertion in src/zobrist.zig at line 67 [2.36]

Insertion in src/uci.zig at line 16 [7.32]

Replacement in src/uci.zig at line 65 [7.32]

Insertion in src/uci.zig at line 77 [7.32]

Insertion in src/uci.zig at line 169 [7.32]

Insertion in src/uci.zig at line 214 [7.32]

Insertion in src/uci.zig at line 241 [7.32]

Insertion in src/perft.zig at line 81 [12.34]

Insertion in src/perft.zig at line 101 [12.34]

Insertion in src/nnue.zig at line 124 [15.33]

Insertion in src/nnue.zig at line 130 [15.33]

Insertion in src/nnue.zig at line 136 [15.33]

Insertion in src/nnue.zig at line 142 [15.33]

Insertion in src/main.zig at line 23 [17.50]

Insertion in src/eval.zig at line 152 [18.33]

Insertion in src/eval.zig at line 162 [18.33]

Insertion in src/eval.zig at line 172 [18.33]

Insertion in src/eval.zig at line 182 [18.33]

Deletion in src/Search.zig at line 36 [19.35]

Deletion in src/Search.zig at line 48 [19.35]

Deletion in src/Search.zig at line 75 [19.35]

Replacement in src/Search.zig at line 78 [19.35]

Deletion in src/Search.zig at line 80 [19.35]

Replacement in src/Search.zig at line 185 [19.35]

Replacement in src/Search.zig at line 245 [19.35]

Replacement in src/Search.zig at line 260 [19.35]

Replacement in src/Search.zig at line 297 [19.35]

Replacement in src/Search.zig at line 301 [19.35]

Replacement in src/Search.zig at line 347 [19.35]

Insertion in src/Board.zig at line 207 [26.16071]

Insertion in src/Board.zig at line 209 [26.16071]

Insertion in src/Board.zig at line 237 [26.16071]

Insertion in src/Board.zig at line 244 [26.16071]

Insertion in src/Board.zig at line 976 [26.16071]

Insertion in src/Board.zig at line 991 [26.16071]

Insertion in src/Board.zig at line 1002 [26.16071]