fiddlerwoaroof/crawl - Change L2HDKXXUL27V7CTKPRAJMUVZNV6ZVSWVEYEOWZZ6NO6O7Y2THDZQC

Clean up acquirement routine by replacing a looooong else block with

an early return.

git-svn-id: https://crawl-ref.svn.sourceforge.net/svnroot/crawl-ref/trunk@10497 c06c8d41-db1a-0410-9941-cceddc491573

Created by j-p-e-g on August 6, 2009

L2HDKXXUL27V7CTKPRAJMUVZNV6ZVSWVEYEOWZZ6NO6O7Y2THDZQC

Dependencies

In channels

main

Change contents

Replacement in crawl-ref/source/effects.cc at line 1721 [5.3382105]
B:BD[5.3417531] → [5.3417531:3417540]
```
    else
```
[5.3417531]
[5.3417540]
```
    int quant = 1;
    for (int item_tries = 0; item_tries < 40; item_tries++)
```

Replacement in crawl-ref/source/effects.cc at line 1725 [5.3382105]

B:BD[5.3417546] → [6.1418:1441]

∅:D[6.1441] → [7.1920:1984]

B:BD[8.16173] → [7.1920:1984]

∅:D[9.1071] → [8.16238:16248]

∅:D[7.1984] → [8.16238:16248]

B:BD[8.16238] → [8.16238:16248]

B:BD[8.16248] → [4.6915:7056]

        int quant = 1;
        for (int item_tries = 0; item_tries < 40; item_tries++)
        {
            int type_wanted = _find_acquirement_subtype(class_wanted, quant,
                                                        agent);

[5.3417546]

[10.2768]

        int type_wanted = _find_acquirement_subtype(class_wanted, quant, agent);

Replacement in crawl-ref/source/effects.cc at line 1727 [5.3382105]

B:BD[10.2769] → [11.7496:7546]

∅:D[11.7546] → [12.1709:1824]

B:BD[12.1709] → [12.1709:1824]

            // Clobber class_wanted for vampires.
            if (you.species == SP_VAMPIRE && class_wanted == OBJ_FOOD)
                class_wanted = OBJ_POTIONS;

[10.2769]

[7.2083]

        // Clobber class_wanted for vampires.
        if (you.species == SP_VAMPIRE && class_wanted == OBJ_FOOD)
            class_wanted = OBJ_POTIONS;

Replacement in crawl-ref/source/effects.cc at line 1731 [5.3382105]

B:BD[7.2084] → [13.15249:15342]

B:BD[13.15342] → [14.5173:5238]

            // Don't generate randart books in items(), we do that
            // ourselves.
            int want_arts = (class_wanted == OBJ_BOOKS ? 0 : 1);

[7.2084]

[13.15405]

        // Don't generate randart books in items(), we do that
        // ourselves.
        int want_arts = (class_wanted == OBJ_BOOKS ? 0 : 1);

Replacement in crawl-ref/source/effects.cc at line 1735 [5.3382105]

B:BD[13.15406] → [13.15406:15485]

∅:D[13.15485] → [15.5916:6040]

B:BD[10.2841] → [15.5916:6040]

            thing_created = items( want_arts, class_wanted, type_wanted, true,
                                   MAKE_GOOD_ITEM, MAKE_ITEM_RANDOM_RACE,
                                   0, 0, agent );

[13.15406]

[8.16427]

        thing_created = items( want_arts, class_wanted, type_wanted, true,
                               MAKE_GOOD_ITEM, MAKE_ITEM_RANDOM_RACE,
                               0, 0, agent );
        if (thing_created == NON_ITEM)
            continue;

Replacement in crawl-ref/source/effects.cc at line 1742 [5.3382105]

B:BD[8.16428] → [8.16428:16497]

            if (thing_created == NON_ITEM)
                continue;

[8.16428]

[8.16497]

        item_def &doodad(mitm[thing_created]);

Replacement in crawl-ref/source/effects.cc at line 1744 [5.3382105]

B:BD[8.16498] → [16.3359:3410]

            item_def &doodad(mitm[thing_created]);

[8.16498]

[4.7057]

        // For mundane armour, try to change the subtype to something
        // matching a currently unfilled equipment slot.
        if (doodad.base_type == OBJ_ARMOUR && !is_artefact(doodad)
            && get_armour_ego_type(doodad) == SPARM_NORMAL)
        {
            _try_give_mundane_armour(doodad);
            if (agent == GOD_OKAWARU && doodad.plus < 0)
                doodad.plus = 0;
        }

Replacement in crawl-ref/source/effects.cc at line 1754 [5.3382105]

B:BD[4.7058] → [4.7058:7504]

            // For mundane armour, try to change the subtype to something
            // matching a currently unfilled equipment slot.
            if (doodad.base_type == OBJ_ARMOUR && !is_artefact(doodad)
                && get_armour_ego_type(doodad) == SPARM_NORMAL)
            {
                _try_give_mundane_armour(doodad);
                if (agent == GOD_OKAWARU && doodad.plus < 0)
                    doodad.plus = 0;
            }

[4.7058]

[4.7504]

        if (doodad.base_type == OBJ_WEAPONS
               && !can_wield(&doodad, false, true)
            || doodad.base_type == OBJ_ARMOUR
               && !can_wear_armour(doodad, false, true))
        {
            destroy_item(thing_created, true);
            thing_created = NON_ITEM;
            continue;
        }

Replacement in crawl-ref/source/effects.cc at line 1764 [5.3382105]

∅:D[16.3410] → [17.5766:5980]

∅:D[4.7505] → [17.5766:5980]

B:BD[9.1129] → [17.5766:5980]

∅:D[18.1271] → [9.1230:1244]

∅:D[19.2725] → [9.1230:1244]

∅:D[20.3959] → [9.1230:1244]

∅:D[17.5980] → [9.1230:1244]

B:BD[9.1230] → [9.1230:1244]

B:BD[9.1244] → [18.1272:1323]

∅:D[18.1323] → [9.1289:1357]

B:BD[9.1289] → [9.1289:1357]

B:BD[9.1357] → [21.2666:2680]

            if (doodad.base_type == OBJ_WEAPONS
                   && !can_wield(&doodad, false, true)
                || doodad.base_type == OBJ_ARMOUR
                   && !can_wear_armour(doodad, false, true))
            {
                destroy_item(thing_created, true);
                thing_created = NON_ITEM;
                continue;
            }

[4.7505]

[21.2680]

        // Only TSO gifts blessed blades, and currently not through
        // acquirement, but make sure of this anyway.
        if (agent != GOD_SHINING_ONE && is_blessed_blade(doodad))
        {
            destroy_item(thing_created, true);
            thing_created = NON_ITEM;
            continue;
        }

Replacement in crawl-ref/source/effects.cc at line 1773 [5.3382105]

B:BD[21.2681] → [22.3079:3151]

B:BD[22.3151] → [2.2671:2729]

∅:D[2.2729] → [17.5981:6051]

B:BD[22.3208] → [17.5981:6051]

            // Only TSO gifts blessed blades, and currently not through
            // acquirement, but make sure of this anyway.
            if (agent != GOD_SHINING_ONE && is_blessed_blade(doodad))

[21.2681]

[21.2853]

        // Trog does not gift the Wrath of Trog, nor weapons of pain
        // (which work together with Necromantic magic).
        if (agent == GOD_TROG)
        {
            int brand = get_weapon_brand(doodad);
            if (brand == SPWPN_PAIN
                || is_unrandom_artefact(doodad)
                   && (doodad.special == UNRAND_TROG
                       || doodad.special == UNRAND_WUCAD_MU))

Deletion in crawl-ref/source/effects.cc at line 1786 [5.3382105]

∅:D[21.3074] → [9.1357:1371]

∅:D[17.6171] → [9.1357:1371]

B:BD[9.1357] → [9.1357:1371]

B:BD[9.1371] → [20.3960:3961]

B:BD[20.3961] → [22.3256:3329]

B:BD[22.3329] → [2.2730:2791]

∅:D[2.2791] → [19.2920:3023]

∅:D[22.3389] → [19.2920:3023]

B:BD[19.2920] → [19.2920:3023]

B:BD[19.3023] → [23.2608:2648]

B:BD[23.2648] → [24.35638:35690]

B:BD[24.35690] → [3.9005:9128]

∅:D[25.4194] → [19.3226:3393]

∅:D[3.9128] → [19.3226:3393]

B:BD[19.3226] → [19.3226:3393]

            }
            // Trog does not gift the Wrath of Trog, nor weapons of pain
            // (which work together with Necromantic magic).
            if (agent == GOD_TROG)
            {
                int brand = get_weapon_brand(doodad);
                if (brand == SPWPN_PAIN
                    || is_unrandom_artefact(doodad)
                       && (doodad.special == UNRAND_TROG
                           || doodad.special == UNRAND_WUCAD_MU))
                {
                    destroy_item(thing_created, true);
                    thing_created = NON_ITEM;
                    continue;
                }

Insertion in crawl-ref/source/effects.cc at line 1787 [5.3382105]
[19.3407]
[19.3407]
```
        }
```

Replacement in crawl-ref/source/effects.cc at line 1789 [5.3382105]

B:BD[19.3408] → [26.2580:2657]

∅:D[26.2657] → [8.16574:16601]

B:BD[8.16574] → [8.16574:16601]

B:BD[8.16601] → [27.160:220]

B:BD[27.220] → [24.35691:35731]

∅:D[27.280] → [8.16700:16714]

∅:D[9.1444] → [8.16700:16714]

∅:D[24.35731] → [8.16700:16714]

B:BD[8.16700] → [8.16700:16714]

B:BD[8.16714] → [28.29954:30060]

∅:D[9.1503] → [29.661:662]

∅:D[8.16785] → [29.661:662]

∅:D[28.30060] → [29.661:662]

B:BD[29.661] → [29.661:662]

B:BD[29.662] → [26.2658:2733]

∅:D[26.2733] → [8.16860:16933]

∅:D[11.7621] → [8.16860:16933]

B:BD[8.16860] → [8.16860:16933]

B:BD[8.16933] → [28.30061:30242]

∅:D[17.6350] → [8.17111:17129]

∅:D[28.30242] → [8.17111:17129]

B:BD[8.17111] → [8.17111:17129]

B:BD[8.17129] → [11.7622:7656]

∅:D[11.7656] → [8.17162:17257]

B:BD[8.17162] → [8.17162:17257]

B:BD[8.17257] → [27.281:311]

∅:D[27.311] → [8.17257:17275]

B:BD[8.17257] → [8.17257:17275]

B:BD[8.17275] → [14.5239:5253]

            // MT - Check: god-gifted weapons and armour shouldn't kill you.
            // Except Xom.
            if ((agent == GOD_TROG || agent == GOD_OKAWARU)
                && is_artefact(doodad))
            {
                artefact_properties_t  proprt;
                artefact_wpn_properties( doodad, proprt );
                // Check vs. stats. positive stats will automatically fall
                // through.  As will negative stats that won't kill you.
                if (-proprt[ARTP_STRENGTH] >= you.strength
                    || -proprt[ARTP_INTELLIGENCE] >= you.intel
                    || -proprt[ARTP_DEXTERITY] >= you.dex)
                {
                    // Try again.
                    destroy_item(thing_created);
                    thing_created = NON_ITEM;
                    continue;
                }
            }

[19.3408]

[14.5253]

        // MT - Check: god-gifted weapons and armour shouldn't kill you.
        // Except Xom.
        if ((agent == GOD_TROG || agent == GOD_OKAWARU)
            && is_artefact(doodad))
        {
            artefact_properties_t  proprt;
            artefact_wpn_properties( doodad, proprt );

Replacement in crawl-ref/source/effects.cc at line 1797 [5.3382105]

B:BD[14.5254] → [14.5254:5552]

            // Sif Muna shouldn't gift Vehumet or Kiku's special books.
            // (The spells therein are still fair game for randart books.)
            if (agent == GOD_SIF_MUNA
                && doodad.sub_type >= MIN_GOD_ONLY_BOOK
                && doodad.sub_type <= MAX_GOD_ONLY_BOOK)

[14.5254]

[14.5552]

            // Check vs. stats. positive stats will automatically fall
            // through.  As will negative stats that won't kill you.
            if (-proprt[ARTP_STRENGTH] >= you.strength
                || -proprt[ARTP_INTELLIGENCE] >= you.intel
                || -proprt[ARTP_DEXTERITY] >= you.dex)

Deletion in crawl-ref/source/effects.cc at line 1803 [5.3382105]
B:BD[14.5566] → [14.5566:5622]
```
                ASSERT(doodad.base_type == OBJ_BOOKS);
```
Deletion in crawl-ref/source/effects.cc at line 1808 [5.3382105]
B:BD[8.17337] → [27.312:331]
```
            break;
```

Replacement in crawl-ref/source/effects.cc at line 1810 [5.3382105]

B:BD[5.3417729] → [5.3417729:3417768]

        if (thing_created == NON_ITEM)

[5.3417729]

[5.3417768]

        // Sif Muna shouldn't gift Vehumet or Kiku's special books.
        // (The spells therein are still fair game for randart books.)
        if (agent == GOD_SIF_MUNA
            && doodad.sub_type >= MIN_GOD_ONLY_BOOK
            && doodad.sub_type <= MAX_GOD_ONLY_BOOK)

Replacement in crawl-ref/source/effects.cc at line 1816 [5.3382105]

B:BD[5.3417778] → [30.1354:1486]

∅:D[30.1486] → [5.3417844:3417872]

∅:D[9.1572] → [5.3417844:3417872]

B:BD[5.3417844] → [5.3417844:3417872]

            if (!quiet)
                mpr("The demon of the infinite void smiles upon you.");
            *item_index = NON_ITEM;
            return (false);

[5.3417778]

[5.3417872]

            ASSERT(doodad.base_type == OBJ_BOOKS);
            // Try again.
            destroy_item(thing_created);
            thing_created = NON_ITEM;
            continue;

Insertion in crawl-ref/source/effects.cc at line 1823 [5.3382105]

[5.3417882]

[31.942129]

        break;
    }
    if (thing_created == NON_ITEM)
    {
        if (!quiet)
            mpr("The demon of the infinite void smiles upon you.");
        *item_index = NON_ITEM;
        return (false);
    }

Replacement in crawl-ref/source/effects.cc at line 1834 [5.3382105]
B:BD[31.942130] → [11.7657:7693]
∅:D[11.7693] → [31.942165:942211]
B:BD[31.942165] → [31.942165:942211]
```
        // Easier to read this way.
        item_def& thing(mitm[thing_created]);
```
[31.942130]
[5.3417882]
```
    // Easier to read this way.
    item_def& thing(mitm[thing_created]);
```

Replacement in crawl-ref/source/effects.cc at line 1837 [5.3382105]

B:BD[5.3417883] → [11.7694:7726]

B:BD[11.7726] → [32.9969:10007]

∅:D[32.10007] → [6.1591:1690]

B:BD[6.1591] → [6.1591:1690]

        // Give some more gold.
        if (class_wanted == OBJ_GOLD)
            thing.quantity += 150;
        else if (quant > 1)
            thing.quantity = quant;

[5.3417883]

[10.2842]

    // Give some more gold.
    if (class_wanted == OBJ_GOLD)
        thing.quantity += 150;
    else if (quant > 1)
        thing.quantity = quant;

Replacement in crawl-ref/source/effects.cc at line 1843 [5.3382105]
B:BD[10.2843] → [33.13466:13502]
∅:D[33.13502] → [34.23446:23491]
B:BD[35.11150] → [34.23446:23491]
```
        if (is_blood_potion(thing))
            init_stack_blood_potions(thing);
```
[10.2843]
[35.11341]
```
    if (is_blood_potion(thing))
        init_stack_blood_potions(thing);
```

Replacement in crawl-ref/source/effects.cc at line 1846 [5.3382105]

B:BD[35.11342] → [11.7727:7767]

B:BD[11.7767] → [26.2734:2766]

        // Remove curse flag from item.
        do_uncurse_item(thing);

[35.11342]

[5.3417970]

    // Remove curse flag from item.
    do_uncurse_item(thing);

Replacement in crawl-ref/source/effects.cc at line 1849 [5.3382105]

B:BD[5.3417971] → [31.942333:942375]

        if (thing.base_type == OBJ_BOOKS)

[5.3417971]

[13.15486]

    if (thing.base_type == OBJ_BOOKS)
    {
        if (!_do_book_acquirement(thing, agent))

Replacement in crawl-ref/source/effects.cc at line 1853 [5.3382105]

B:BD[13.15496] → [36.5724:6024]

∅:D[36.6024] → [37.22161:22195]

∅:D[13.15544] → [37.22161:22195]

B:BD[31.942375] → [37.22161:22195]

            if (!_do_book_acquirement(thing, agent))
            {
                if (!quiet)
                    mpr("The demon of the infinite void smiles upon you.");
                *item_index = NON_ITEM;
                destroy_item(thing, true);
                return (false);
            }
            mark_had_book(thing);

[13.15496]

[13.15545]

            if (!quiet)
                mpr("The demon of the infinite void smiles upon you.");
            *item_index = NON_ITEM;
            destroy_item(thing, true);
            return (false);

Replacement in crawl-ref/source/effects.cc at line 1859 [5.3382105]

∅:D[13.15555] → [31.942727:942778]

∅:D[37.22195] → [31.942727:942778]

B:BD[5.3418886] → [31.942727:942778]

        else if (thing.base_type == OBJ_JEWELLERY)

[13.15555]

[5.3418951]

        mark_had_book(thing);
    }
    else if (thing.base_type == OBJ_JEWELLERY)
    {
        switch (thing.sub_type)

Replacement in crawl-ref/source/effects.cc at line 1865 [5.3382105]

B:BD[5.3418961] → [31.942779:942815]

∅:D[31.942815] → [5.3419011:3419056]

B:BD[5.3419011] → [5.3419011:3419056]

B:BD[5.3419056] → [11.7768:7821]

B:BD[11.7821] → [38.23387:23448]

∅:D[38.23448] → [10.2844:2879]

B:BD[31.942941] → [10.2844:2879]

            switch (thing.sub_type)
            {
            case RING_SLAYING:
                // Make sure plus to damage is >= 1.
                thing.plus2 = std::max(abs(thing.plus2), 1);
                // fall through...

[5.3418961]

[5.3419325]

        case RING_SLAYING:
            // Make sure plus to damage is >= 1.
            thing.plus2 = std::max(abs(thing.plus2), 1);
            // fall through...

Replacement in crawl-ref/source/effects.cc at line 1870 [5.3382105]

B:BD[5.3419326] → [5.3419326:3419492]

B:BD[5.3419492] → [32.10008:10051]

B:BD[32.10051] → [38.23449:23508]

∅:D[38.23508] → [5.3419711:3419734]

∅:D[31.943063] → [5.3419711:3419734]

B:BD[5.3419711] → [5.3419711:3419734]

            case RING_PROTECTION:
            case RING_STRENGTH:
            case RING_INTELLIGENCE:
            case RING_DEXTERITY:
            case RING_EVASION:
                // Make sure plus is >= 1.
                thing.plus = std::max(abs(thing.plus), 1);
                break;

[5.3419326]

[5.3419734]

        case RING_PROTECTION:
        case RING_STRENGTH:
        case RING_INTELLIGENCE:
        case RING_DEXTERITY:
        case RING_EVASION:
            // Make sure plus is >= 1.
            thing.plus = std::max(abs(thing.plus), 1);
            break;

Replacement in crawl-ref/source/effects.cc at line 1879 [5.3382105]

B:BD[5.3419735] → [5.3419735:3419798]

B:BD[5.3419798] → [32.10052:10121]

∅:D[32.10121] → [5.3419866:3419905]

B:BD[5.3419866] → [5.3419866:3419905]

B:BD[5.3419905] → [38.23509:23555]

∅:D[38.23555] → [5.3419967:3419990]

∅:D[31.943112] → [5.3419967:3419990]

B:BD[5.3419967] → [5.3419967:3419990]

            case RING_HUNGER:
            case AMU_INACCURACY:
                // These are the only truly bad pieces of jewellery.
                if (!one_chance_in(9))
                    make_item_randart(thing);
                break;

[5.3419735]

[5.3419990]

        case RING_HUNGER:
        case AMU_INACCURACY:
            // These are the only truly bad pieces of jewellery.
            if (!one_chance_in(9))
                make_item_randart(thing);
            break;

Replacement in crawl-ref/source/effects.cc at line 1886 [5.3382105]

B:BD[5.3419991] → [5.3419991:3420049]

            default:
                break;
            }

[5.3419991]

[5.3420049]

        default:
            break;

Replacement in crawl-ref/source/effects.cc at line 1889 [5.3382105]

B:BD[5.3420059] → [31.943113:943161]

B:BD[26.2813] → [26.2813:2863]

        else if (thing.base_type == OBJ_WEAPONS
                 && !is_unrandom_artefact(thing))

[5.3420059]

[5.3420187]

    }
    else if (thing.base_type == OBJ_WEAPONS
             && !is_unrandom_artefact(thing))
    {
        // HACK: Make unwieldable weapons wieldable.
        // Note: messing with fixed artefacts is probably very bad.
        switch (you.species)

Replacement in crawl-ref/source/effects.cc at line 1897 [5.3382105]

B:BD[5.3420197] → [32.10122:10179]

∅:D[10.2936] → [5.3420254:3420359]

∅:D[32.10179] → [5.3420254:3420359]

B:BD[5.3420254] → [5.3420254:3420359]

            // HACK: Make unwieldable weapons wieldable.
            // Note: messing with fixed artefacts is probably very bad.
            switch (you.species)

[5.3420197]

[5.3420359]

        case SP_DEMONSPAWN:
        case SP_MUMMY:
        case SP_GHOUL:
        case SP_VAMPIRE:
        {
            int brand = get_weapon_brand(thing);
            if (brand == SPWPN_HOLY_WRATH)

Replacement in crawl-ref/source/effects.cc at line 1905 [5.3382105]

B:BD[5.3420373] → [5.3420373:3420459]

B:BD[5.3420459] → [39.584:613]

            case SP_DEMONSPAWN:
            case SP_MUMMY:
            case SP_GHOUL:
            case SP_VAMPIRE:

[5.3420373]

[5.3420459]

                if (is_random_artefact(thing))

Replacement in crawl-ref/source/effects.cc at line 1907 [5.3382105]

B:BD[5.3420477] → [38.23556:23613]

∅:D[38.23613] → [40.4611:4662]

B:BD[31.943273] → [40.4611:4662]

                    int brand = get_weapon_brand(thing);
                    if (brand == SPWPN_HOLY_WRATH)

[5.3420477]

[5.3420659]

                    // Keep resetting seed until it's good.
                    for (; brand == SPWPN_HOLY_WRATH;
                         brand = get_weapon_brand(thing))

Replacement in crawl-ref/source/effects.cc at line 1911 [5.3382105]

B:BD[5.3420681] → [24.35732:35787]

∅:D[38.23670] → [5.3420753:3420779]

∅:D[24.35787] → [5.3420753:3420779]

∅:D[31.943332] → [5.3420753:3420779]

B:BD[5.3420753] → [5.3420753:3420779]

B:BD[5.3421005] → [32.10180:10248]

∅:D[32.10248] → [10.2992:3054]

B:BD[31.943457] → [10.2992:3054]

∅:D[10.3054] → [31.943458:943525]

∅:D[40.4726] → [31.943458:943525]

B:BD[5.3421203] → [31.943458:943525]

∅:D[31.943525] → [5.3421284:3421314]

B:BD[5.3421284] → [5.3421284:3421314]

B:BD[5.3421314] → [38.23753:23811]

∅:D[10.3115] → [5.3421392:3421448]

∅:D[38.23811] → [5.3421392:3421448]

∅:D[31.943590] → [5.3421392:3421448]

B:BD[5.3421392] → [5.3421392:3421448]

B:BD[5.3421448] → [24.35788:35950]

                        if (is_random_artefact(thing))
                        {
                            // Keep resetting seed until it's good.
                            for (; brand == SPWPN_HOLY_WRATH;
                                  brand = get_weapon_brand(thing))
                            {
                                make_item_randart(thing);
                            }
                        }
                        else
                        {
                            set_item_ego_type(thing, OBJ_WEAPONS, SPWPN_VORPAL);
                        }

[5.3420681]

[5.3421448]

                        make_item_randart(thing);

Replacement in crawl-ref/source/effects.cc at line 1914 [5.3382105]

B:BD[5.3421488] → [5.3421488:3421542]

B:BD[5.3421569] → [5.3421569:3421627]

B:BD[5.3421627] → [31.943591:943631]

                break;
            case SP_HALFLING:
            case SP_KOBOLD:
            case SP_SPRIGGAN:
                switch (thing.sub_type)

[5.3421488]

[5.3421681]

                else

Replacement in crawl-ref/source/effects.cc at line 1916 [5.3382105]

B:BD[5.3421699] → [31.943632:943739]

                case WPN_LONGBOW:
                    thing.sub_type = WPN_BOW;
                    break;

[5.3421699]

[31.943739]

                    set_item_ego_type(thing, OBJ_WEAPONS, SPWPN_VORPAL);
                }
            }
            break;
        }

Replacement in crawl-ref/source/effects.cc at line 1922 [5.3382105]

∅:D[31.943740] → [5.3421699:3421776]

B:BD[5.3421699] → [5.3421699:3421776]

B:BD[5.3421776] → [41.16715:16798]

∅:D[41.16798] → [5.3421902:3421929]

B:BD[5.3421902] → [5.3421902:3421929]

                case WPN_GREAT_SWORD:
                case WPN_TRIPLE_SWORD:
                    thing.sub_type = (coinflip() ? WPN_FALCHION : WPN_LONG_SWORD);
                    break;

[31.943740]

[5.3421929]

        case SP_HALFLING:
        case SP_KOBOLD:
        case SP_SPRIGGAN:
            switch (thing.sub_type)
            {
            case WPN_LONGBOW:
                thing.sub_type = WPN_BOW;
                break;

Replacement in crawl-ref/source/effects.cc at line 1931 [5.3382105]

B:BD[5.3421930] → [5.3421930:3421967]

B:BD[5.3421967] → [31.943780:943817]

B:BD[31.943817] → [41.16799:16873]

∅:D[41.16873] → [5.3422122:3422149]

B:BD[5.3422122] → [5.3422122:3422149]

                case WPN_GREAT_MACE:
                case WPN_DIRE_FLAIL:
                    thing.sub_type = (coinflip() ? WPN_MACE : WPN_FLAIL);
                    break;

[5.3421930]

[5.3422149]

            case WPN_GREAT_SWORD:
            case WPN_TRIPLE_SWORD:
                thing.sub_type = (coinflip() ? WPN_FALCHION : WPN_LONG_SWORD);
                break;

Replacement in crawl-ref/source/effects.cc at line 1936 [5.3382105]

B:BD[5.3422150] → [5.3422150:3422229]

B:BD[5.3422229] → [41.16874:16954]

∅:D[41.16954] → [5.3422352:3422379]

B:BD[5.3422352] → [5.3422352:3422379]

                case WPN_BATTLEAXE:
                case WPN_EXECUTIONERS_AXE:
                    thing.sub_type = (coinflip() ? WPN_HAND_AXE : WPN_WAR_AXE);
                    break;

[5.3422150]

[5.3422379]

            case WPN_GREAT_MACE:
            case WPN_DIRE_FLAIL:
                thing.sub_type = (coinflip() ? WPN_MACE : WPN_FLAIL);
                break;

Replacement in crawl-ref/source/effects.cc at line 1941 [5.3382105]

B:BD[5.3422380] → [5.3422380:3422480]

B:BD[5.3422480] → [42.628:663]

B:BD[42.663] → [41.16955:17032]

∅:D[41.17032] → [5.3422600:3422645]

B:BD[5.3422600] → [5.3422600:3422645]

                case WPN_HALBERD:
                case WPN_GLAIVE:
                case WPN_SCYTHE:
                case WPN_BARDICHE:
                    thing.sub_type = (coinflip() ? WPN_SPEAR : WPN_TRIDENT);
                    break;
                }

[5.3422380]

[5.3422645]

            case WPN_BATTLEAXE:
            case WPN_EXECUTIONERS_AXE:
                thing.sub_type = (coinflip() ? WPN_HAND_AXE : WPN_WAR_AXE);

Replacement in crawl-ref/source/effects.cc at line 1946 [5.3382105]

B:BD[5.3422669] → [5.3422669:3422690]

            default:

[5.3422669]

[5.3422690]

            case WPN_HALBERD:
            case WPN_GLAIVE:
            case WPN_SCYTHE:
            case WPN_BARDICHE:
                thing.sub_type = (coinflip() ? WPN_SPEAR : WPN_TRIDENT);

Insertion in crawl-ref/source/effects.cc at line 1953 [5.3382105]
[43.7384]
[10.3268]
```
            break;
```

Replacement in crawl-ref/source/effects.cc at line 1955 [5.3382105]

∅:D[10.3269] → [43.7397:7435]

B:BD[43.7397] → [43.7397:7435]

B:BD[43.7477] → [43.7477:7526]

B:BD[43.7526] → [44.3104:3151]

∅:D[44.3151] → [43.7526:7606]

B:BD[43.7526] → [43.7526:7606]

B:BD[43.7606] → [24.35951:35992]

∅:D[24.35992] → [45.347:423]

B:BD[45.347] → [45.347:423]

∅:D[45.423] → [5.3422713:3422727]

∅:D[43.7606] → [5.3422713:3422727]

B:BD[5.3422713] → [5.3422713:3422727]

B:BD[43.7649] → [43.7649:7706]

B:BD[43.7706] → [44.3152:3199]

∅:D[44.3199] → [43.7706:7786]

B:BD[43.7706] → [43.7706:7786]

B:BD[43.7786] → [24.35993:36034]

∅:D[24.36034] → [45.472:550]

B:BD[45.472] → [45.472:550]

B:BD[5.3424679] → [5.3424679:3424693]

            int plusmod = random2(4);
            if (agent == GOD_TROG)
            {
                // More damage, less accuracy.
                thing.plus  -= plusmod;
                thing.plus2 += plusmod;
                if (!is_artefact(thing))
                    thing.plus = std::max(static_cast<int>(thing.plus), 0);
            }
            else if (agent == GOD_OKAWARU)
            {
                // More accuracy, less damage.
                thing.plus  += plusmod;
                thing.plus2 -= plusmod;
                if (!is_artefact(thing))
                    thing.plus2 = std::max(static_cast<int>(thing.plus2), 0);
            }

[10.3269]

[5.3424693]

        default:
            break;
        }
        int plusmod = random2(4);
        if (agent == GOD_TROG)
        {
            // More damage, less accuracy.
            thing.plus  -= plusmod;
            thing.plus2 += plusmod;
            if (!is_artefact(thing))
                thing.plus = std::max(static_cast<int>(thing.plus), 0);
        }
        else if (agent == GOD_OKAWARU)
        {
            // More accuracy, less damage.
            thing.plus  += plusmod;
            thing.plus2 -= plusmod;
            if (!is_artefact(thing))
                thing.plus2 = std::max(static_cast<int>(thing.plus2), 0);

Insertion in crawl-ref/source/effects.cc at line 1976 [5.3382105]
[5.3424703]
[5.3424703]
```
    }
```

Replacement in crawl-ref/source/effects.cc at line 1978 [5.3382105]

B:BD[5.3424704] → [37.22196:22273]

∅:D[17.6361] → [46.3241:3285]

B:BD[46.3241] → [46.3241:3285]

        if (agent > GOD_NO_GOD && agent < NUM_GODS && agent == you.religion)
            thing.inscription = "god gift";

[5.3424704]

[24.36035]

    if (agent > GOD_NO_GOD && agent < NUM_GODS && agent == you.religion)
        thing.inscription = "god gift";

Replacement in crawl-ref/source/effects.cc at line 1981 [5.3382105]
∅:D[24.36036] → [47.44043:44099]
B:BD[17.6681] → [47.44043:44099]
```
        move_item_to_grid( &thing_created, you.pos() );
```
[24.36036]
[5.3424771]
```
    move_item_to_grid( &thing_created, you.pos() );
```

Replacement in crawl-ref/source/effects.cc at line 1983 [5.3382105]

B:BD[5.3424772] → [5.3424772:3424841]

B:BD[5.3424841] → [10.3270:3339]

∅:D[10.3339] → [5.3424911:3424999]

B:BD[5.3424911] → [5.3424911:3424999]

B:BD[5.3424999] → [48.450157:450167]

B:BD[48.450167] → [30.1487:1562]

B:BD[48.450225] → [48.450225:450235]

B:BD[48.450235] → [30.1563:1600]

        // This should never actually be NON_ITEM because of the way
        // move_item_to_grid works (doesn't create a new item ever),
        // but we're checking it anyways. -- bwr
        if (thing_created != NON_ITEM)
        {
            if (!quiet)
                canned_msg(MSG_SOMETHING_APPEARS);
        }
        *item_index = thing_created;

[5.3424772]

[5.3425046]

    // This should never actually be NON_ITEM because of the way
    // move_item_to_grid works (doesn't create a new item ever),
    // but we're checking it anyways. -- bwr
    if (thing_created != NON_ITEM)
    {
        if (!quiet)
            canned_msg(MSG_SOMETHING_APPEARS);

Insertion in crawl-ref/source/effects.cc at line 1991 [5.3382105]
[5.3425052]
[5.3425052]
```
    *item_index = thing_created;
```